Merged
Conversation
benk-mira
requested changes
May 26, 2025
| """Construct models from the local drivers.""" | ||
| raise NotImplementedError("Must be implemented by subclass.") | ||
| @property | ||
| def mapping(self): |
Contributor
There was a problem hiding this comment.
mapping and mappings are a little to close. Maybe mappings -> driver_mapping?
Collaborator
Author
There was a problem hiding this comment.
This is redefining the self.mapping of the BaseDriver class.
# Conflicts: # simpeg_drivers/__init__.py
benk-mira
previously approved these changes
May 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #216 +/- ##
===========================================
+ Coverage 90.47% 90.75% +0.28%
===========================================
Files 86 88 +2
Lines 5123 5279 +156
Branches 662 672 +10
===========================================
+ Hits 4635 4791 +156
Misses 325 325
Partials 163 163
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-789 - Joint inversion: PGI