GEOPY-2232: Refactor components of inversion options#221
Merged
domfournier merged 62 commits intodevelopfrom Jun 11, 2025
Merged
GEOPY-2232: Refactor components of inversion options#221domfournier merged 62 commits intodevelopfrom
domfournier merged 62 commits intodevelopfrom
Conversation
# Conflicts: # simpeg_drivers/options.py
github-actions
bot
changed the title
(cherry picked from commit 927b700) # Conflicts: # simpeg_drivers/options.py
This reverts commit f5dd1f4.
benk-mira
previously approved these changes
Jun 9, 2025
Contributor
benk-mira
left a comment
benk-mira
left a comment
There was a problem hiding this comment.
Nice work, like the organization!
| "enabled": true, | ||
| "tooltip": "Lp-norm used in the z-smoothness term of the objective function." | ||
| }, | ||
| "gradient_type": "total", |
Contributor
There was a problem hiding this comment.
won't this produce ifile.data and ui_json different length warnings?
Collaborator
Author
There was a problem hiding this comment.
Not anymore since I am using self.model_dump(exclude_unset=True) and ifile.update_ui_values instead. So only the values that were assigned get changed. For standard ui.json runs that is all of them since coming from file, but for local test runs only partial.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #221 +/- ##
===========================================
- Coverage 91.02% 90.74% -0.28%
===========================================
Files 85 85
Lines 5101 5034 -67
Branches 652 650 -2
===========================================
- Hits 4643 4568 -75
- Misses 298 300 +2
- Partials 160 166 +6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2232 - Refactor components of inversion options