Skip to content

GEOPY-2303: Change units displayed on selector of data type for V/Am^2 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 3 commits into from
Jul 24, 2025
Merged

GEOPY-2303: Change units displayed on selector of data type for V/Am^2 #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd866b1
Change tooltip and options in uijson
domfournier Jul 22, 2025
3e55749
Adjust code for changes
domfournier Jul 22, 2025
7daaccb
New edits to tooltip from scott
domfournier Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions simpeg_drivers-assets/uijson/tdem1d_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,20 @@
},
"data_units": {
"choiceList": [
"dB/dt (T/s)",
"B (T)",
"H (A/m)"
"Airborne dB/dt (V/Am^4)",
"Airborne B (T/Am^2)",
"Ground dB/dt (V/Am^2)",
"Ground B (T/A)"
],
"group": "Survey",
"main": true,
"label": "Data type",
"tooltip": "Set the units of the data",
"tooltip": [
"Set the units of the data.<dl>",
"Data are expected to be normalized by the source strength, dependent on the type:<dl>",
"<dt>Dipole</dt><dd>Current * area * number of turns (NIA).</dd><dl>",
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>"
],
"value": "dB/dt (T/s)"
},
"z_channel_bool": {
Expand Down
16 changes: 11 additions & 5 deletions simpeg_drivers-assets/uijson/tdem1d_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,20 @@
},
"data_units": {
"choiceList": [
"dB/dt (T/s)",
"B (T)",
"H (A/m)"
"Airborne dB/dt (V/Am^4)",
"Airborne B (T/Am^2)",
"Ground dB/dt (V/Am^2)",
"Ground B (T/A)"
],
"group": "Data",
"group": "Survey",
"main": true,
"label": "Data type",
"tooltip": "Set the units of the data",
"tooltip": [
"Set the units of the data.<dl>",
"Data are expected to be normalized by the source strength, dependent on the type:<dl>",
"<dt>Dipole</dt><dd>Current * area * number of turns (NIA).</dd><dl>",
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>"
],
"value": "dB/dt (T/s)"
},
"z_channel": {
Expand Down
14 changes: 10 additions & 4 deletions simpeg_drivers-assets/uijson/tdem_forward.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,20 @@
},
"data_units": {
"choiceList": [
"dB/dt (T/s)",
"B (T)",
"H (A/m)"
"Airborne dB/dt (V/Am^4)",
"Airborne B (T/Am^2)",
"Ground dB/dt (V/Am^2)",
"Ground B (T/A)"
],
"group": "Survey",
"main": true,
"label": "Data type",
"tooltip": "Set the units of the data",
"tooltip": [
"Set the units of the data.<dl>",
"Data are expected to be normalized by the source strength, dependent on the type:<dl>",
"<dt>Dipole</dt><dd>Current * area * number of turns (NIA).</dd><dl>",
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>"
],
"value": "dB/dt (T/s)"
},
"z_channel_bool": {
Expand Down
16 changes: 11 additions & 5 deletions simpeg_drivers-assets/uijson/tdem_inversion.ui.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,20 @@
},
"data_units": {
"choiceList": [
"dB/dt (T/s)",
"B (T)",
"H (A/m)"
"Airborne dB/dt (V/Am^4)",
"Airborne B (T/Am^2)",
"Ground dB/dt (V/Am^2)",
"Ground B (T/A)"
],
"group": "Data",
"group": "Survey",
"main": true,
"label": "Data type",
"tooltip": "Set the units of the data",
"tooltip": [
"Set the units of the data.<dl>",
"Data are expected to be normalized by the source strength, dependent on the type:<dl>",
"<dt>Dipole</dt><dd>Current * area * number of turns (NIA).</dd><dl>",
"<dt>Wire</dt><dd>Current * number of turns (NI).</dd>"
],
"value": "dB/dt (T/s)"
},
"z_channel": {
Expand Down
2 changes: 1 addition & 1 deletion simpeg_drivers/components/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ def get_normalizations(self):
)
elif (
"tdem" in self.params.inversion_type
and self.params.data_units == "dB/dt (T/s)"
and "dB/dt" in self.params.data_units
):
if comp in ["x", "y", "z"]:
normalizations[chan][comp] = -1
Expand Down
4 changes: 2 additions & 2 deletions simpeg_drivers/components/factories/receiver_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def concrete_object(self):
elif "tdem" in self.factory_type:
from simpeg.electromagnetics.time_domain import receivers

if self.params.data_units == "dB/dt (T/s)":
if "dB/dt" in self.params.data_units:
return receivers.PointMagneticFluxTimeDerivative
elif self.params.data_units == "B (T)":
elif "B (T" in self.params.data_units:
return receivers.PointMagneticFluxDensity
else:
return receivers.PointMagneticField
Expand Down
4 changes: 2 additions & 2 deletions simpeg_drivers/electromagnetics/time_domain/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ class BaseTDEMOptions(EMDataMixin):

:param data_object: The data object containing the TDEM data.
:param physical_property: The physical property being modeled (e.g., conductivity).
:param data_units: The units of the TDEM data (e.g., "dB/dt (T/s)").
:param data_units: The units of the TDEM data (e.g., "Airborne dB/dt (V/Am^4)").
"""

data_units: str = "dB/dt (T/s)"
data_units: str = "Airborne dB/dt (V/Am^4)"

@property
def unit_conversion(self):
Expand Down