GEOPY-2387: force use of MKL for Blas implementation#250
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR forces the use of MKL for BLAS implementation across all platforms by uncommenting the libblas = "*=*mkl" specification in pyproject.toml. The change consolidates BLAS implementation to use Intel MKL consistently, which is already brought in by the simpeg dependency.
- Uncomments and enables MKL BLAS specification in conda-lock dependencies
- Removes platform-specific MKL configurations from individual Python environment files
- Updates all conda lock files with new dependency hashes and package versions
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Enables MKL BLAS dependency specification |
| py-3.*.conda-lock.yml | Updates lock files with new dependency hashes and package versions |
| environments/*.conda.lock.yml | Updates environment-specific lock files |
| environments/env-python-*.yml | Removes redundant MKL specifications |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
domfournier
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2387 - use again MKL for Blas implementation on Windows instead of OpenBlas