GEOPY-2389: Refactor of the Factory classes#252
Merged
domfournier merged 62 commits intodevelopfrom Aug 20, 2025
Merged
Conversation
… Slice the ordering
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
===========================================
+ Coverage 91.68% 91.72% +0.03%
===========================================
Files 108 109 +1
Lines 5893 5860 -33
Branches 711 697 -14
===========================================
- Hits 5403 5375 -28
- Misses 309 310 +1
+ Partials 181 175 -6
🚀 New features to boost your workflow:
|
benk-mira
requested changes
Aug 19, 2025
Contributor
benk-mira
left a comment
There was a problem hiding this comment.
Looks good. Just some suggestions for docstring/typing on some old utils.
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml # py-3.10.conda-lock.yml # py-3.11.conda-lock.yml # py-3.12.conda-lock.yml
# Conflicts: # tests/locations_test.py # tests/run_tests/driver_2d_rotated_gradients_test.py # tests/run_tests/driver_dc_2d_test.py # tests/run_tests/driver_dc_b2d_rotated_gradients_test.py # tests/run_tests/driver_dc_b2d_test.py # tests/run_tests/driver_dc_test.py # tests/run_tests/driver_ground_tem_test.py # tests/run_tests/driver_ip_2d_test.py # tests/run_tests/driver_ip_b2d_test.py
benk-mira
previously approved these changes
Aug 20, 2025
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # environments/py-3.11-linux-64-dev.conda.lock.yml # environments/py-3.11-linux-64.conda.lock.yml # environments/py-3.11-win-64-dev.conda.lock.yml # environments/py-3.11-win-64.conda.lock.yml # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-linux-64.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.12-win-64.conda.lock.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2389 - Refactor of the Factory classes