Skip to content

GEOPY-2389: Refactor of the Factory classes#252

Merged
domfournier merged 62 commits intodevelopfrom
GEOPY-2389
Aug 20, 2025
Merged

GEOPY-2389: Refactor of the Factory classes#252
domfournier merged 62 commits intodevelopfrom
GEOPY-2389

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Aug 14, 2025

GEOPY-2389 - Refactor of the Factory classes

@github-actions github-actions bot changed the title GEOPY-2389 GEOPY-2389: Refactor of the Factory classes Aug 14, 2025
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 98.20051% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.72%. Comparing base (2bf8a2d) to head (4445cae).
⚠️ Report is 63 commits behind head on develop.

Files with missing lines Patch % Lines
...peg_drivers/components/factories/misfit_factory.py 92.85% 1 Missing and 1 partial ⚠️
simpeg_drivers/utils/nested.py 98.87% 0 Missing and 2 partials ⚠️
simpeg_drivers/driver.py 94.73% 1 Missing ⚠️
simpeg_drivers/electromagnetics/base_1d_driver.py 88.88% 0 Missing and 1 partial ⚠️
simpeg_drivers/utils/surveys.py 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #252      +/-   ##
===========================================
+ Coverage    91.68%   91.72%   +0.03%     
===========================================
  Files          108      109       +1     
  Lines         5893     5860      -33     
  Branches       711      697      -14     
===========================================
- Hits          5403     5375      -28     
- Misses         309      310       +1     
+ Partials       181      175       -6     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 92.47% <100.00%> (-0.70%) ⬇️
...drivers/components/factories/directives_factory.py 98.30% <100.00%> (+2.24%) ⬆️
...g_drivers/components/factories/receiver_factory.py 86.66% <100.00%> (-0.44%) ⬇️
...drivers/components/factories/simulation_factory.py 93.25% <100.00%> (-5.69%) ⬇️
...peg_drivers/components/factories/survey_factory.py 94.89% <100.00%> (-0.50%) ⬇️
...peg_drivers/electromagnetics/time_domain/driver.py 100.00% <ø> (+4.54%) ⬆️
...eg_drivers/electromagnetics/time_domain/options.py 100.00% <100.00%> (ø)
simpeg_drivers/joint/driver.py 93.88% <100.00%> (ø)
simpeg_drivers/options.py 94.77% <100.00%> (-0.16%) ⬇️
simpeg_drivers/utils/tile_estimate.py 86.71% <100.00%> (-2.26%) ⬇️
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some suggestions for docstring/typing on some old utils.

# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
# Conflicts:
#	tests/locations_test.py
#	tests/run_tests/driver_2d_rotated_gradients_test.py
#	tests/run_tests/driver_dc_2d_test.py
#	tests/run_tests/driver_dc_b2d_rotated_gradients_test.py
#	tests/run_tests/driver_dc_b2d_test.py
#	tests/run_tests/driver_dc_test.py
#	tests/run_tests/driver_ground_tem_test.py
#	tests/run_tests/driver_ip_2d_test.py
#	tests/run_tests/driver_ip_b2d_test.py
benk-mira
benk-mira previously approved these changes Aug 20, 2025
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
@domfournier domfournier merged commit 7cbef46 into develop Aug 20, 2025
14 checks passed
@domfournier domfournier deleted the GEOPY-2389 branch August 20, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants