Skip to content

GEOPY-2395: Add check for negative cond/res model values#268

Merged
domfournier merged 5 commits intodevelopfrom
GEOPY-2395
Sep 12, 2025
Merged

GEOPY-2395: Add check for negative cond/res model values#268
domfournier merged 5 commits intodevelopfrom
GEOPY-2395

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Sep 11, 2025

GEOPY-2395 - Add check for negative cond/res model values

@github-actions github-actions bot changed the title GEOPY-2395 GEOPY-2395: Add check for negative cond/res model values Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.54%. Comparing base (585c07e) to head (60bc1e2).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
simpeg_drivers/driver.py 36.36% 6 Missing and 1 partial ⚠️
simpeg_drivers/options.py 33.33% 4 Missing ⚠️
...peg_drivers/components/factories/entity_factory.py 50.00% 1 Missing ⚠️
...peg_drivers/components/factories/survey_factory.py 66.66% 1 Missing ⚠️
...ivers/electromagnetics/frequency_domain/options.py 50.00% 1 Missing ⚠️
simpeg_drivers/joint/joint_surveys/options.py 50.00% 1 Missing ⚠️
simpeg_drivers/line_sweep/driver.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #268      +/-   ##
===========================================
- Coverage    91.58%   91.54%   -0.04%     
===========================================
  Files          110      110              
  Lines         5868     5879      +11     
  Branches       713      714       +1     
===========================================
+ Hits          5374     5382       +8     
- Misses         312      315       +3     
  Partials       182      182              
Files with missing lines Coverage Δ
simpeg_drivers/components/models.py 84.43% <100.00%> (+0.09%) ⬆️
...peg_drivers/components/factories/entity_factory.py 77.33% <50.00%> (+0.30%) ⬆️
...peg_drivers/components/factories/survey_factory.py 94.89% <66.66%> (ø)
...ivers/electromagnetics/frequency_domain/options.py 90.90% <50.00%> (+0.16%) ⬆️
simpeg_drivers/joint/joint_surveys/options.py 90.47% <50.00%> (+0.47%) ⬆️
simpeg_drivers/line_sweep/driver.py 88.32% <50.00%> (+0.08%) ⬆️
simpeg_drivers/options.py 94.77% <33.33%> (ø)
simpeg_drivers/driver.py 85.07% <36.36%> (-0.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier domfournier merged commit b900c29 into develop Sep 12, 2025
12 of 14 checks passed
@domfournier domfournier deleted the GEOPY-2395 branch September 12, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants