Skip to content

GEOPY-2364: Detect issues with waveform and throw a custom GeoappsError if found #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 1 commit into from
Sep 15, 2025
Merged

GEOPY-2364: Detect issues with waveform and throw a custom GeoappsError if found #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions simpeg_drivers/components/factories/survey_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,12 @@ def _dcip_arguments(self, data=None):
def _tdem_arguments(self, data=None):
receivers = data.entity
transmitters = receivers.transmitters
channels = np.array(receivers.channels) * self.params.unit_conversion

if receivers.channels[-1] > (
receivers.waveform[:, 0].max() - receivers.timing_mark
):
if any(channels > (self.params.time_steps.sum() - self.params.timing_mark)):
raise GeoAppsError(
f"The latest time channel {receivers.channels[-1]} exceeds "
f"the waveform discretization. Revise waveform."
f"the waveform discretization. Check waveform sampling from start to end."
)

if isinstance(transmitters, LargeLoopGroundTEMTransmitters):
Expand Down Expand Up @@ -239,6 +238,16 @@ def _tdem_arguments(self, data=None):
receivers.waveform[:, 0] - receivers.timing_mark
) * self.params.unit_conversion

# Check single channel per time gate
_, count = np.unique(
np.searchsorted(wave_times, channels, side="right"), return_counts=True
)
if np.any(count > 1):
raise GeoAppsError(
"Multiple channels found within single time step. "
"Check waveform sampling on the off-times."
)

if "1d" in self.factory_type:
on_times = wave_times <= 0.0
waveform = tdem.sources.PiecewiseLinearWaveform(
Expand Down
6 changes: 6 additions & 0 deletions tests/run_tests/driver_airborne_tem_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ def test_bad_waveform(tmp_path: Path):
with raises(GeoAppsError, match="The latest time"):
_ = fwr_driver.inversion_data.survey

with geoh5:
params.data_object.channels[-1] = 0.7

with raises(GeoAppsError, match="Multiple channels found within single time step"):
_ = fwr_driver.inversion_data.survey


def test_airborne_tem_fwr_run(
tmp_path: Path,
Expand Down
Loading