Skip to content

Fix some null strings generations in dumpinfo.py #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abbas-MG wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some null strings generations in dumpinfo.py #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 57 additions & 1 deletion src_plugins/ida/fakepdb/dumpinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,17 @@
# PE
#


def safe_str(value, counter, default="UNKNOWN"):
if value is None:
return default + str(counter)
if isinstance(value, str):
if value.strip() == "":
return default + str(counter)
return value
return str(value)


class PE_Struct(object):

def __init__(self, packinfo, data):
Expand Down Expand Up @@ -718,6 +729,7 @@ def __process_general(self):
def __process_segments(self):
segments = list()

unkIdx = 0
for n in range(0, ida_segment.get_segm_qty()):
seg = ida_segment.getnseg(n)
if seg:
Expand All @@ -731,7 +743,35 @@ def __process_segments(self):
'selector' : seg.sel,
'type' : ida_segment.get_segm_class(seg),
}




problem = False

segm['name'] = safe_str(segm.get('name'), unkIdx)
if segm['name'].startswith("UNKNOWN"):
problem = True
print('Encountered a nameless segment:')
print(f" location: {seg.start_ea:X} => try analyzing this address")
print(" Segment name changed to: " + segm['name'] + '\n')

segm['permission'] = safe_str(segm.get('permission'), unkIdx)
if segm['permission'].startswith("UNKNOWN"):
problem = True
print('Encountered a segment permission problem:')
print(f" name: {segm['name']} location: {seg.start_ea:X} => try analyzing")
print(" Segment permission changed to: " + segm['permission'] + '\n')

segm['type'] = safe_str(segm.get('type'), unkIdx)
if segm['type'].startswith("UNKNOWN"):
problem = True
print('Encountered a segment type problem:')
print(f" name: {segm['name']} location: {seg.start_ea:X} => try analyzing")
print(" Segment type changed to: " + segm['type'] + '\n')

if problem:
unkIdx = unkIdx + 1

segments.append(segm)

return segments
Expand Down Expand Up @@ -806,6 +846,7 @@ def __process_functions(self):

func = chunk

unkIdx = 0
while func and func.start_ea < end:
start_ea = func.start_ea

Expand All @@ -823,6 +864,13 @@ def __process_functions(self):
'is_autonamed' : func_autonamed
}

function['name'] = safe_str(function.get('name'), unkIdx )
if function['name'].startswith("UNKNOWN"):
unkIdx = unkIdx + 1
print('Encountered a nameless function:')
print(f" location: {start_ea:X} => try analyzing this address")
print(" Function name changed to: " + function['name'] + '\n')

# PE32/PE32+ only support binaries up to 2GB
if function['start_rva'] >= 2**32:
print('RVA out of range for function: ' + function['name'], file=sys.stderr)
Expand All @@ -840,6 +888,7 @@ def __process_functions(self):
def __process_names(self):
names = list()

unkIdx = 0
for i in range(0, ida_name.get_nlist_size()):
ea = ida_name.get_nlist_ea(i)
if ida_funcs.get_func(ea) is not None:
Expand All @@ -856,6 +905,13 @@ def __process_names(self):
'is_func' : ida_funcs.get_func(ea) is not None
}

name['name'] = safe_str(name.get('name'), unkIdx)
if name['name'] == "UNKNOWN":
unkIdx = unkIdx + 1
print('Encountered a null Name:')
print(f" location: {ea:X} => try analyzing this address")
print(" Name changed to: " + name['name'] + '\n')

# PE32/PE32+ only support binaries up to 2GB
if name['rva'] >= 2**32:
print('RVA out of range for name: ' + name['name'], file=sys.stderr)
Expand Down
Loading