fix: stop SettingsPage crashing on cold load#656
Merged
Conversation
On a hard refresh, there's one render where the query's settings have resolved but the effect syncing localSettings hasn't run yet. The old post-gate invariant threw on that render, and hasUnsavedChanges dereferenced a null localSettings. Guard both paths and show the loading spinner until localSettings is populated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settingshave resolved (soloadingis false) but theuseEffectthat syncslocalSettingshasn't fired yet — leavinglocalSettings === null.throw'd, andhasUnsavedChangesdereferenced the nulllocalSettingsviabuildChangedPayload(null is not an object).hasUnsavedChangesagainst nulllocalSettings, and replace the post-gatethrowwith the loading spinner so the page waits one render for the sync effect.if (loading)branch into the single!settings || !localSettingsspinner gate (isLoadingis only true when there's no data yet), dropping the unusedloadingbinding.useEffectsync rather than a render-time ref check —localSettingsis settings-form state (a copy of server data the user edits independently), which CLAUDE.md designates as the correct case for effect-based syncing.Test plan
/settings(each tab) — page loads without crashing/settingsfrom a warm cache — no spinner flash, content renders immediately