Skip to content

Better errors#128

Merged
remyCases merged 12 commits intomainfrom
BetterErrors
Sep 22, 2025
Merged

Better errors#128
remyCases merged 12 commits intomainfrom
BetterErrors

Conversation

@remyCases
Copy link
Copy Markdown
Collaborator

This PR adds several improvement in the logging system:

  • Improvement:

    • removes all useless catch/rethow that were only a rethrow
    • fixes all logging as lazy
    • improves stability of save and load
    • better error message when a patch fails
  • Misc:

    • simplifies the text on the dialog that pops when a patch fails
    • adds a log error if loading a YYC file, and reset internal memory

…s, adds the new checksum value and removes older ones, log an error if users load a yyc file and handle gracefully its error, improves stability when loading a file.
…e failed, no more uses of try/catch in async button related functions and a better something went wrong error message
@remyCases remyCases added this to the Minor Update 0.14.0.0 milestone Sep 7, 2025
@remyCases remyCases requested a review from altairwei September 7, 2025 23:13
@remyCases remyCases added the type:enhancement New feature or request label Sep 7, 2025
@altairwei
Copy link
Copy Markdown
Collaborator

Does this PR include your new design of error window?

@remyCases
Copy link
Copy Markdown
Collaborator Author

It does not yet. It contains the error window without the stacktrace, I'll work on the new window later

Comment thread ModLoader.cs

if (modType == null)
{
MessageBox.Show("加载错误: " + assembly.GetName().Name + " 此Mod需要一个Mod类");
Copy link
Copy Markdown
Collaborator

@altairwei altairwei Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be translated to:

MessageBox.Show("Loading error: " + assembly.GetName().Name + " This Mod need a Mod class");

@remyCases remyCases requested a review from altairwei September 21, 2025 20:16
@remyCases
Copy link
Copy Markdown
Collaborator Author

@altairwei I've added the new design of error window

@remyCases remyCases merged commit 368dfb0 into main Sep 22, 2025
1 check passed
@remyCases remyCases deleted the BetterErrors branch September 22, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants