Make library.db authoritative for MLIP metadata#42
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (22)
📝 WalkthroughWalkthroughThe change makes MLIP library metadata authoritative and read-only, removes legacy MLIP metadata-mode configuration, updates importer caching and invalidation, blocks metadata mutations across platforms, expands desktop index lookup, and raises the fallback application version to 1.0.0. ChangesMLIP metadata read-only behavior
Application version baseline
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant SourceForm
participant MlipLibraryIndexImporter
participant BangumiIndexMetadataCoordinator
participant AnimeDetailViewModel
SourceForm->>MlipLibraryIndexImporter: configure MLIP source without metadata mode
MlipLibraryIndexImporter->>BangumiIndexMetadataCoordinator: expose MLIP-managed metadata
BangumiIndexMetadataCoordinator-->>AnimeDetailViewModel: return read-only status
AnimeDetailViewModel-->>SourceForm: disable rescrape and manual matching
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
library.dbas the sole metadata authority for MLIP sources and replace historical local overrides on every scanFILES_ONLYand local-priority controls; block manual and batch metadata writes for MLIP-managed entriesBreaking behavior
mlipMetadataModerequest/config values remain deserializable but are ignoredlibrary.db; local re-scraping is no longer available0.11.0to1.0.0because this changes existing configuration semanticsValidation
./gradlew.bat :core:model:test :data:testDebugUnitTest :scanner:testDebugUnitTest :repository-api:test :repository-desktop:test :sync-engine-shared:test :web-control-core:test :ui-tv:testDebugUnitTest :desktop-app:test :app:assembleDebug :desktop-app:compileKotlinnpm run buildinweb-control/frontendadb install -r, UIAutomator verification of the read-onlylibrary.dbsettings state, and crash-log checkA real HK1 MLIP scan was intentionally not triggered before review to avoid rewriting the current device library without an explicit post-merge action.
Summary by CodeRabbit
New Features
Bug Fixes
User Interface