Peer Feedback Activity

[DebbyMiressa]

Instructions

• Once you get a pull request link from your partner, go ahead and review it:
  • Reminder: How to give a code review.
• Check the quality of the code (you can use previous lessons as a guide). Remember to check for the following:
  • JavaScript best practices.
  • DRY, KISS, and YAGNI rules.
  • HTML & CSS best practices.
• Finish your review with a nice summary.
• Compare your review with the issue created by the project's author in the Do I follow JavaScript best practices? exercise.
• There is no need to add anything to your review at this point. It is just to check if you both noticed the same issues.
• Check the review you received from your partner! You will make improvements to your code based on your partner's review in the next exercise.

[mohamed20163858]

hello Debby, your work is fantastic your code is clear and clean I think there is nothing to do I just have optional things to comment about.

1. you can use fontawesome website to select icons for your code instead of blurry icons.
2. I think it will be better to implement the whole functionalities without refreshing your webpage like the behavior of the original application.

[mohamed20163858]

you should put .eslintrc.json, .stylelintrc.json and .hintrc to your .gitignore file as professionally these files should not be uploaded to your GitHub as a best practice

[DebbyMiressa]

When I try to add the Linters to the .gitignore, nothing happens. The git is not ignoring them.

[mohamed20163858]

now your changes are accepted thanks for taking time to do them