[222_54] fix: override tooltip to Toggle cell alignment in tabular context only.#2974
Open
Prashant27-07 wants to merge 1 commit intoMoganLab:mainfrom
Open
[222_54] fix: override tooltip to Toggle cell alignment in tabular context only.#2974Prashant27-07 wants to merge 1 commit intoMoganLab:mainfrom
Prashant27-07 wants to merge 1 commit intoMoganLab:mainfrom
Conversation
Contributor
Author
|
Hey @JackYansongLi @Yuki-Nagori I raised another PR for same issue hope this will has no conflict at all because i checked all the thing this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2852
The tooltip "Toggle numbering" was misleading - the button actually toggles cell alignment (tabular vs tabular*). Override alternate-first-icon, alternate-second-icon, alternate-first-name and alternate-second-name in table-menu.scm to show correct icons and tooltip only in tabular context using table-markup-context?.