[222_60] Correct macOS modifier symbols in accent shortcut tooltips#2982
Merged
Yuki-Nagori merged 2 commits intoMoganLab:mainfrom Mar 18, 2026
Merged
[222_60] Correct macOS modifier symbols in accent shortcut tooltips#2982Yuki-Nagori merged 2 commits intoMoganLab:mainfrom
Yuki-Nagori merged 2 commits intoMoganLab:mainfrom
Conversation
Prthmsh7
changed the title
Contributor
Author
|
@JackYansongLi please review when free, thanks! |
Contributor
|
The number needs to be updated. I checked the code and there's no problem. |
Prthmsh7
changed the title
Contributor
Author
|
@Yuki-Nagori Updated numbering in a follow-up commit. Please review when free. Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2962
This patch ensures that modifier symbols are correctly rendered in Qt tooltips on macOS through two small adjustments:
1. Tooltip UTF-8 Conversion
In
src/Plugins/Qt/qt_ui_element.cpp, tooltip text is now passed throughcork_to_utf8()before being converted to a Qt string. This converts TeXmacs character references into their proper Unicode symbols so that Qt displays them correctly.2. macOS Shortcut Rendering Condition
In
src/Texmacs/Server/tm_config.cpp, thekbd_system_prevailscondition was refined to avoid applying legacy modifier substitutions when macOS fonts are already being used. This prevents conflicts with the font-based rendering of macOS modifier symbols.After:
