Chore/ferret v2.0.0 alpha.30#54
Merged
Merged
Conversation
…move unused artifact.Marshal argument
…nd update built-in module logic
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps Ferret v2 and multiple contrib modules, and wires new built-in runtime modules so Ferret CLI scripts can use additional document/database capabilities (PDF, XLSX, PostgreSQL). It also updates artifact serialization to match the updated Ferret API.
Changes:
- Update
github.com/MontFerret/ferret/v2tov2.0.0-alpha.30and refresh severalcontribmodule versions. - Register new built-in modules in the builtin runtime:
db/postgres,document/pdf, anddocument/xlsx. - Simplify artifact serialization callsite to
artifact.Marshal(program).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/runtime/builtin_modules.go | Registers new built-in modules (postgres/pdf/xlsx) and adds a document module initializer group. |
| pkg/build/artifact.go | Updates artifact serialization call to match the new artifact.Marshal signature. |
| go.mod | Bumps Ferret/contrib module versions and adds new dependencies needed by the new built-in modules. |
| go.sum | Records updated module checksums after the dependency upgrade (including new transitive deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
84
to
88
| func dbMods(_ Options) ([]module.Module, error) { | ||
| return []module.Module{ | ||
| postgres.New(), | ||
| sqlite.New(), | ||
| }, nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies and extends the application's built-in modules to add new document and database capabilities. The main focus is on supporting PDF, XLSX, and PostgreSQL, along with updating several existing modules to newer versions.
Dependency and Module Updates:
Dependency upgrades and additions:
github.com/MontFerret/contribmodules andgithub.com/MontFerret/ferret/v2to newer versions ingo.mod, ensuring access to bug fixes and new features.github.com/ledongthuc/pdf,github.com/xuri/excelize/v2, andgithub.com/jackc/pgx/v5.New built-in module support:
pdf,xlsx) and a new database module (postgres) in the runtime by updatingpkg/runtime/builtin_modules.go. This allows scripts to directly use PDF, XLSX, and PostgreSQL features. [1] [2] [3] [4]Minor code simplification:
artifact.Marshalcall inpkg/build/artifact.goby removing the unusedartifact.Options{}parameter.