Tolerate one-ULP BF16 variation in correctness tests - #16
Open
morluto wants to merge 1 commit into
Open
Conversation
morluto
marked this pull request as ready for review
July 27, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Replace bitwise BF16 kernel/reference assertions with a one-ULP comparison while keeping FP32 state checks exact.
Relates to #12.
Motivation
Issue #12 reports that the forward test passes with CUDA 12.9 on B200 but fails with CUDA 13 because
torch.equalobserves a small BF16 output difference.The kernel and Torch reference intentionally reproduce BF16 intermediate rounding. Requiring identical BF16 bits across compiler versions makes the test more restrictive than the numerical behavior it is intended to validate.
Comparison contract
Changes
Suggested review order
tests/numerics.py— comparison contract and bounded-memory implementation.tests/test_numerics.py— edge-case coverage.tests/test_fwd.pyandtests/test_fwd_full.py— integration at existing assertion sites.README.md— user-facing description.The main question is whether one representable BF16 value is the appropriate boundary. Differences beyond that boundary still fail.
Validation
python -m pytest -q tests/test_numerics.py— 4 passed.python -m py_compile tests/numerics.py tests/test_numerics.py tests/test_fwd.py tests/test_fwd_full.pygit diff --check origin/master...HEAD