Report CUTLASS setup and CUDA launch-configuration failures - #19
Open
morluto wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fail at the operation that caused a setup or CUDA configuration error instead of continuing to a later, less actionable failure.
Closes #15.
Motivation
Two initialization boundaries currently discard errors:
cudaFuncSetAttributeresultsC10_CUDA_CHECKThe documented clone and submodule workflow remains valid. This change improves reporting when that workflow or launch configuration fails.
Changes
git submodule update --init cutlassfrom the repository root.check=Truefor the Git subprocess.cudaFuncSetAttributecalls withC10_CUDA_CHECK.No architecture selection, kernel launch dimensions, shared-memory sizes, or successful setup behavior changes.
Suggested review order
build_utils.py— setup failure boundary and diagnostics.tests/test_build_utils.py— subprocess behavior.setup.pyandMANIFEST.in— setup integration and source-distribution inclusion.csrc/smxx/fwd_launch.cu— CUDA error propagation.The two commits are intentionally separated: the first implements the diagnostics, and the second ensures the new setup helper is present in source distributions.
Validation
python -m pytest -q tests/test_build_utils.py— 3 passed.build_utils.py.C10_CUDA_CHECK.python -m py_compile build_utils.py setup.py tests/test_build_utils.pygit diff --check origin/master...HEAD