fix(web): catch aiohttp.ClientError in SearchWeb to prevent unhandled crash#1586
Open
ascl1u wants to merge 2 commits intoMoonshotAI:mainfrom
Open
fix(web): catch aiohttp.ClientError in SearchWeb to prevent unhandled crash#1586ascl1u wants to merge 2 commits intoMoonshotAI:mainfrom
ascl1u wants to merge 2 commits intoMoonshotAI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SearchWeb.__call__does not catchaiohttp.ClientError, so network failures propagate as unhandled exceptions and crash the agent loop.FetchURLin the same package already handles this correctly.This PR wraps the
session.post()call in atry/except aiohttp.ClientErrorblock and returns a graceful tool error, matching the existing pattern infetch.py.Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.