-
Notifications
You must be signed in to change notification settings - Fork 809
fix(shell): use git ls-files for @ file mention in large repos #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n-WN
wants to merge
15
commits into
MoonshotAI:main
Choose a base branch
from
n-WN:fix/file-mention-git-ls-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
66f97ce
fix(shell): use git ls-files for @ file mention discovery (#1375)
n-WN 1d08761
style: ruff format prompt.py
n-WN 1117293
refactor: unify web/shell file mention logic via shared file_filter m…
n-WN 38324b1
refactor: align file_filter style with codebase conventions
n-WN 28a6a54
fix: prevent path traversal in file mention scope parameter
n-WN b7736ef
fix(web): restore unfiltered directory listing in file browser API
n-WN 9c5e334
fix: preserve filename whitespace in git ls-files output parsing
n-WN 88230bc
fix: filter ignored dirs and stale paths from git ls-files results
n-WN 246052c
fix: prune empty directory entries after deleted-file filtering
n-WN 570f925
test: add file_filter cross-validation tests (git vs walk parity)
n-WN 4f2b1f9
fix: use git ls-files -z for NUL-delimited output parsing
n-WN 7416521
fix: add -- separator before scope path in git ls-files commands
n-WN 89450c4
fix: handle submodule dirty state in deleted/untracked file discovery
n-WN a575855
Revert "fix: handle submodule dirty state in deleted/untracked file d…
n-WN aaaa0ca
docs: regenerate changelog for file mention and web panel changes
n-WN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a repo is detected, deep
@completion now callslist_files_gitwithout applyingself._limit, so the candidate set becomes unbounded while theos.walkfallback still enforces the limit. In large repos this can feed tens of thousands of paths intoFuzzyCompleteron each completion request, causing noticeable UI latency and negating the guardrail that thelimitconstructor argument previously provided.Useful? React with 👍 / 👎.