fix: resolve full PowerShell path on Windows#1703
Open
elis132 wants to merge 2 commits intoMoonshotAI:mainfrom
Open
fix: resolve full PowerShell path on Windows#1703elis132 wants to merge 2 commits intoMoonshotAI:mainfrom
elis132 wants to merge 2 commits intoMoonshotAI:mainfrom
Conversation
The bare `powershell.exe` filename fails with `[WinError 2]` when `asyncio.create_subprocess_exec` cannot find it on PATH (common in uv tool virtual environments). Use `%SystemRoot%` to build the full path, which works on any standard Windows installation. Fixes MoonshotAI#1702
Update test_environment_detection_windows to expect the full PowerShell path and monkeypatch SystemRoot for deterministic results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Shell tool is completely broken on Windows when installed via
uv tool install. Every shell command fails with:environment.pysetsshell_path = KaosPath("powershell.exe")— a bare filename. Whenasyncio.create_subprocess_exec()tries to launch it,CreateProcessWcannot findpowershell.exebecause the uv virtual environment PATH does not includeC:\Windows\System32\WindowsPowerShell\v1.0\.Fix
Resolve the full path using the
SystemRootenvironment variable (always set on Windows):Verification
Fixes #1702