Skip to content

refactor(agent-core): rename micro compaction telemetry event to micro_compaction_finished#846

Merged
7Sageer merged 7 commits into
MoonshotAI:mainfrom
7Sageer:refactor/micro-compaction-finished-event
Jun 17, 2026
Merged

refactor(agent-core): rename micro compaction telemetry event to micro_compaction_finished#846
7Sageer merged 7 commits into
MoonshotAI:mainfrom
7Sageer:refactor/micro-compaction-finished-event

Conversation

@7Sageer

@7Sageer 7Sageer commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Depends on #845. This PR is stacked on top of #845. Until #845 is merged, the diff and commit list will also include the commits from #845; they will drop out automatically once #845 lands on main.

Related Issue

No related issue.

Problem

The telemetry events for the two compaction paths use inconsistent verbs: full compaction emits compaction_finished / compaction_failed, while micro compaction emitted micro_compaction_applied. The mixed applied vs finished wording makes the two paths harder to discover and compare.

What changed

Renamed the micro compaction telemetry event from micro_compaction_applied to micro_compaction_finished, so both compaction paths now follow the same <kind>_compaction_finished convention.

Full compaction's compaction_finished / compaction_failed are intentionally left untouched. The records.logRecord entry (micro_compaction.apply) is also left as-is, since it is an internal replay record rather than a telemetry event.

Note: this is a telemetry event rename. Micro compaction is still gated behind the experimental micro_compaction flag (disabled by default), so the data footprint of the old event name is small.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue, or explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 34461b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@34461b8
npx https://pkg.pr.new/@moonshot-ai/kimi-code@34461b8

commit: 34461b8

@7Sageer 7Sageer force-pushed the refactor/micro-compaction-finished-event branch from c1ff2a3 to d7288f3 Compare June 17, 2026 12:13
@7Sageer 7Sageer merged commit 53cab36 into MoonshotAI:main Jun 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant