refactor(agent-core): rename micro compaction telemetry event to micro_compaction_finished#846
Merged
7Sageer merged 7 commits intoJun 17, 2026
Conversation
|
commit: |
c1ff2a3 to
d7288f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No related issue.
Problem
The telemetry events for the two compaction paths use inconsistent verbs: full compaction emits
compaction_finished/compaction_failed, while micro compaction emittedmicro_compaction_applied. The mixedappliedvsfinishedwording makes the two paths harder to discover and compare.What changed
Renamed the micro compaction telemetry event from
micro_compaction_appliedtomicro_compaction_finished, so both compaction paths now follow the same<kind>_compaction_finishedconvention.Full compaction's
compaction_finished/compaction_failedare intentionally left untouched. Therecords.logRecordentry (micro_compaction.apply) is also left as-is, since it is an internal replay record rather than a telemetry event.Note: this is a telemetry event rename. Micro compaction is still gated behind the experimental
micro_compactionflag (disabled by default), so the data footprint of the old event name is small.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.