Fix telemetry error UI#374
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made:
Component Updates:
Added error state tracking to TelemetryDashboard component
Implemented visible error UI with clear messaging
Enhanced error message display with monospace font and styled container
Added ARIA attributes for accessibility (role="alert", aria-live="assertive", aria-labels)
Kept refresh and export actions available during error states
Extracted error message handling into a reusable function
Added comprehensive JSDoc documentation
Test Coverage (21 tests):
Basic error display tests
Button availability tests during errors
Retry functionality tests
Error message handling tests (Error objects, strings, null)
Export functionality tests during error state
Accessibility tests for ARIA attributes
Loading state clearing tests
Styling verification tests
Success case tests
Acceptance Criteria Met:
✅ Render a visible error state when analytics data cannot load
✅ Keep refresh and export actions available when appropriate
✅ Add tests for failed dashboard loads (21 comprehensive tests)
Closes #339