Fix/postgresql pool configuration#377
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Implementation:
Added pool configuration constants (max, idle timeout, connection timeout, statement timeout)
Created parsePoolConfig() function to parse environment variables with validation
Updated PostgresEventStore to accept and apply pool configuration
Integrated pool config into the event store factory function
Added validation warning for excessive pool sizes (>100)
Exported constants for testing purposes
Testing: 7. Added comprehensive unit tests for parsePoolConfig() function 8. Added integration tests for pool configuration 9. Added test for validation warning 10. Added test to verify default constants 11. All 101 tests passing
Closes #347