Fix/reject requests during shutdown#378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Implementation:
Added shutdown state tracking with module-level variable
Imported shutdown state checker in server
Created ServiceUnavailableError class (503 status)
Imported ServiceUnavailableError in server
Added checkShutdownState() helper function
Reject ingest requests during shutdown
Added Retry-After header (30 seconds) for 503 responses
Record metrics for rejected shutdown requests
Log request rejection during shutdown
Export checkShutdownState for testing
Testing: 11. Added test for ServiceUnavailableError 12. Added graceful shutdown unit test 13. Added shutdown integration tests 14. Updated server integration tests 15. Verified all 105 tests pass
Closes #351