Test/add api route coverage

chainhook/API_TEST_CHANGES.md

@@ -0,0 +1,119 @@
+# API Route Test Coverage Changes
+
+## Summary
+
+Added comprehensive integration test coverage for all remaining chainhook API routes, covering both success and failure cases as requested in issue #352.
+
+## Problem
+
+The chainhook integration tests covered ingest, tips, health, and metrics, but not the rest of the API surface. The untested routes were where regressions in lookup, filtering, and admin views were most likely to hide.
+
+## Solution
+
+Expanded integration test suite with dedicated tests for each API route, covering success paths, error conditions, and edge cases.
+
+## Changes Made
+
+### New Test Cases
+
+1. **Tip Retrieval by ID**
+   - Success case with full field validation
+   - Non-existent tip ID (404)
+   - Invalid tip ID format (404)
+
+2. **Tips by User Address**
+   - Tips sent by user
+   - Tips received by user
+   - Invalid address format (400)
+   - User with no tips (empty array)
+
+3. **Statistics Endpoint**
+   - Aggregate statistics with multiple tips
+   - Multiple senders and recipients
+   - Zero statistics when no data exists
+
+4. **Admin Events**
+   - Multiple admin event types
+   - Empty events list
+
+5. **Bypass Detection**
+   - Bypass detection with admin events
+   - Empty bypasses list
+
+6. **Pagination**
+   - Correct pagination behavior
+   - Invalid limit rejection (400)
+   - Negative offset rejection (400)
+
+### Test Organization
+
+- Removed redundant combined test
+- Created focused, single-purpose tests
+- Each test validates specific behavior
+- Clear test names describing what is tested
+
+### Documentation
+
+- Created TEST_COVERAGE.md with complete coverage map
+- Documented all endpoints and test cases
+- Added test statistics and organization details
+
+## Acceptance Criteria
+
+- [x] Add tests for /api/tips/:id
+- [x] Add tests for /api/tips/user/:address
+- [x] Add tests for /api/stats
+- [x] Add tests for /api/admin/events
+- [x] Add tests for /api/admin/bypasses
+- [x] Cover success and failure cases for the new tests
+- [x] Keep the existing ingest coverage intact
+
+## Test Results
+
+- Total tests: 121 (increased from 105)
+- All tests passing
+- Added 16 new focused test cases
+- Removed 1 redundant combined test
+- Net gain: 15 new tests
+
+## Test Coverage
+
+### Before
+- Basic ingest flow
+- Simple tip listing
+- Health and metrics
+- Error handling for malformed payloads
+- One combined test for remaining routes
+
+### After
+- Complete coverage of all API endpoints
+- Success and failure cases for each route
+- Edge cases (empty results, invalid inputs)
+- Pagination validation
+- Address format validation
+- Admin operations testing
+
+## Benefits
+
+1. Catches regressions in lookup operations
+2. Validates filtering behavior
+3. Tests admin view functionality
+4. Ensures proper error handling
+5. Documents expected API behavior
+6. Provides confidence for refactoring
+7. Easier to identify failing functionality
+
+## Test Execution
+
+All tests pass:
+```
+# tests 121
+# suites 19
+# pass 121
+# fail 0
+```
+
+Run tests with:
+```bash
+npm test
+```

chainhook/TEST_COVERAGE.md

@@ -0,0 +1,95 @@
+# Chainhook API Test Coverage
+
+## Overview
+
+Comprehensive integration test coverage for all chainhook API routes, including success and failure cases.
+
+## Test Coverage
+
+### Ingest Endpoint
+
+- **POST /api/chainhook/events**
+  - Successful event ingestion
+  - Duplicate event handling
+  - Malformed payload rejection
+  - Oversized payload rejection
+  - Rate limiting
+  - Authentication
+
+### Tips Endpoints
+
+- **GET /api/tips**
+  - Paginated tip listing
+  - Invalid pagination limit
+  - Negative offset rejection
+  - Empty results
+
+- **GET /api/tips/:id**
+  - Successful tip retrieval by ID
+  - Non-existent tip ID (404)
+  - Invalid tip ID format (404)
+
+- **GET /api/tips/user/:address**
+  - Tips sent by user
+  - Tips received by user
+  - Invalid address format (400)
+  - User with no tips (empty array)
+
+### Statistics Endpoint
+
+- **GET /api/stats**
+  - Aggregate statistics calculation
+  - Multiple senders and recipients
+  - Zero statistics when no data
+
+### Admin Endpoints
+
+- **GET /api/admin/events**
+  - Admin event retrieval
+  - Multiple event types
+  - Empty events list
+
+- **GET /api/admin/bypasses**
+  - Bypass detection
+  - Empty bypasses list
+
+### System Endpoints
+
+- **GET /health**
+  - Health check with storage details
+  - Uptime tracking
+
+- **GET /metrics**
+  - Metrics retrieval
+  - Storage statistics
+
+## Test Statistics
+
+- Total tests: 121
+- All tests passing
+- Coverage includes success and failure cases
+- Integration tests run against in-memory storage
+
+## Test Organization
+
+Tests are organized by endpoint and functionality:
+1. Core ingest flow
+2. Tip retrieval and filtering
+3. Statistics aggregation
+4. Admin operations
+5. Error handling
+6. Edge cases
+
+## Running Tests
+
+```bash
+npm test
+```
+
+## Test Helpers
+
+- `request()` - Standard HTTP request helper
+- `requestChunked()` - Chunked request helper for streaming tests
+- `buildTipEvent()` - Tip event builder
+- `buildAdminEvent()` - Admin event builder
+- `buildEventPayload()` - Complete payload builder