Fix/validate chainhook payloads#380
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Implementation:
Added payload structure validation helper
Added block structure validation
Added transaction structure validation
Integrated validation into extractEvents
Added warning logs for events missing value
Exported validation functions for testing
Testing: 7. Added payload structure validation tests 8. Added block validation tests 9. Added transaction validation tests 10. Added integration test for missing apply field 11. Added test for missing block_identifier 12. Added test for missing transaction_identifier 13. Added test for empty apply array 14. Updated extractEvents test for validation 15. Verified all 140 tests pass
Documentation: 16. Added payload validation documentation 17. Added payload validation to features list 18. Added validation section to README 19. Updated package description with validation 20. Added common validation error examples 21. Added comprehensive validation changes summary
Closes #348