Fix/reset enrichment state on visible change#381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Was Fixed
Infinite Loop Issue: Removed tipMessages from effect dependencies and used a ref-based cache tracking system to prevent infinite re-renders
Stale State Detection: Added visible set change detection to identify when the tip list changes materially
Request Cancellation: Implemented request ID tracking to properly cancel stale requests during rapid pagination
State Reconciliation: Added logic to clear or filter cached state based on overlap with previous visible set
Loading State Management: Improved loading state handling to prevent stale indicators
Key Technical Changes
Used tipMessagesRef to track cache state without triggering effect re-runs
Implemented request ID system to prevent race conditions
Added clearCounter state to force recalculation after manual clear
Simplified cleanup logic to avoid premature request cancellation
Added comprehensive inline documentation
Testing
All 14 tests pass successfully
Added tests for rapid pagination, filtering, and stale state prevention
Verified no regressions in existing functionality
Closes #340