Skip to content

fix: Update MIME type handling in CustomWebChromeClient #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkusnierz wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: Update MIME type handling in CustomWebChromeClient #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/src/main/java/ca/cgagnier/wlednativeandroid/ui/components/DeviceWebview.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,13 +389,14 @@ class CustomWebChromeClient(private val context: Context) : WebChromeClient() {

private fun getMimeType(acceptTypes: Array<String>): String {
for (type in acceptTypes) {
return when (type) {
".json" -> "application/json"
".css" -> "text/css"
return when {
type == ".json" -> "application/json"
type == ".css" -> "text/css"
type.contains("/") -> type
else -> continue
}
Comment on lines +392 to 397
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of hardcoding specific extensions like .json and .css, you can use android.webkit.MimeTypeMap to support a wider range of file types.

Also, note that this logic returns the first valid MIME type found and ignores any subsequent ones. If a web page specifies multiple types (e.g., accept="image/*, application/pdf"), the file picker will be restricted to only the first type, preventing the user from selecting others. For a more robust implementation, consider handling multiple MIME types or falling back to */* when more than one type is provided.

Suggested change
return when {
type == ".json" -> "application/json"
type == ".css" -> "text/css"
type.contains("/") -> type
else -> continue
}
return when {
type.startsWith(".") -> android.webkit.MimeTypeMap.getSingleton()
.getMimeTypeFromExtension(type.substring(1)) ?: continue
type.contains("/") -> type
else -> continue
}

}
return "application/octet-stream"
return "*/*"
}
}

Expand Down