Support https/wss and other Add Device UI improvements

[smitty078]

Implements the following changes

URL Handling

• Normalize and store canonical device base URLs instead of raw hostnames/IPs
• Add centralized URL and websocket URL handling (http/https → ws/wss)
• Update webview, websocket, and OTA update flows to consume canonical URLs directly

User Interface

• DeviceAddView:

  • Supports manual entry of full URLs, ports, and HTTPS devices
  • Supports entering Custom Name right from device add
  • Displayed as NavigationStack/Group instead of Navigation/VStack, which makes it behave more modern and native

• DeviceInfoTwoRows:

  • Truncates long URLs so that the view width never gets clipped in narrow parent views

[gemini-code-assist]

Code Review

This pull request introduces the ControllerAddress utility to handle URL normalization and WebSocket endpoint generation. The review feedback suggests adding validation to ensure only 'http' or 'https' schemes are accepted to prevent errors in WebSocket URL construction, and recommends replacing the deprecated appendingPathComponent method with the modern appending(path:) API.

[smitty078]

/gemini review

[smitty078]

/gemini summary

[gemini-code-assist]

Code Review

This pull request implements support for secure connections (HTTPS/WSS) and improves device address normalization across the application. Key changes include the addition of computed URL and WebSocket URL properties to the Device model, a redesigned device addition interface featuring a secure connection toggle and custom naming, and fixes for path construction in the update service. Review feedback identifies an empty localization entry for 'Device Added' and recommends refactoring duplicated address normalization logic into a shared utility to improve maintainability.

[gemini-code-assist]

Summary of Changes

This pull request introduces robust support for secure connections (HTTPS/WSS) by standardizing how device URLs are stored and processed throughout the application. It refactors the device addition flow to provide a more native user experience, including manual URL entry, custom naming, and better feedback during the connection process. These changes ensure consistent URL handling across webviews, websocket clients, and OTA update services.

Highlights

• URL Normalization: Implemented centralized canonical URL handling, replacing raw hostnames with full URL objects to support both http and https/wss protocols.
• Device Addition UI: Modernized the Device Add flow using NavigationStack, added support for custom device names, and included a secure connection toggle.
• UI/UX Improvements: Enhanced device information display with text truncation to prevent layout clipping and added localized warning banners for local network permissions.

Activity

• Initial pull request created by smitty078.
• Automated review identified issues with URL scheme validation and deprecated API usage.
• Automated review highlighted duplicate normalization logic and missing localization strings.
• Author requested a summary of the changes.

[smitty078]

/gemini review

[gemini-code-assist]

Code Review

This pull request enhances device management by introducing a centralized DeviceAddressNormalizer and updating the Device model to provide computed url and webSocketURL properties. The "Add Device" interface has been refactored to support custom device names and a toggle for secure connections, while the underlying services now utilize the normalized address logic. Additionally, the PR fixes a file path bug in the update service and improves the UI for device status and addition. Review feedback highlights a potential desync in the secure connection toggle logic and identifies localization issues with interpolated strings in SwiftUI views.