feat: Add robust logging and update device list#3
Open
amirmohammadrazmy wants to merge 1 commit intoMrPooyaX:mainfrom
Open
feat: Add robust logging and update device list#3amirmohammadrazmy wants to merge 1 commit intoMrPooyaX:mainfrom
amirmohammadrazmy wants to merge 1 commit intoMrPooyaX:mainfrom
Conversation
This commit introduces two main changes to help diagnose why the application is no longer working.
1. **Add Robust Logging:**
- Implemented a `Log()` method to write timestamped events and errors to a `log.txt` file.
- Refactored the main `hamle()` loop to remove the silent `try-catch` block.
- Added granular error handling to log the full, raw server response when an API call (authorize, upgradableApps) fails.
- Added a top-level exception handler to catch and log any unexpected errors, such as network failures.
2. **Update Device List:**
- Replaced the contents of `devices.txt` with a more current list of popular Android devices from 2023.
Note: The project could not be compiled in the environment due to the absence of .NET build tools. The user will need to compile the project in their own environment to generate the new executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces two main changes to help diagnose why the application is no longer working.
Add Robust Logging:
Log()method to write timestamped events and errors to alog.txtfile.hamle()loop to remove the silenttry-catchblock.Update Device List:
devices.txtwith a more current list of popular Android devices from 2023.Note: The project could not be compiled in the environment due to the absence of .NET build tools. The user will need to compile the project in their own environment to generate the new executable.