Skip to content

build!: bump dependencies, require node 24#58

Merged
MrSquaare merged 2 commits into
mainfrom
57-support-node-24-for-github-actions-runners
Mar 13, 2026
Merged

build!: bump dependencies, require node 24#58
MrSquaare merged 2 commits into
mainfrom
57-support-node-24-for-github-actions-runners

Conversation

@MrSquaare
Copy link
Copy Markdown
Owner

@MrSquaare MrSquaare commented Mar 13, 2026

Pull Request

Related issue(s)

Resolves #57

Description

  • Bump dependencies
  • Require Node.js 24 runtime

Summary by CodeRabbit

  • Chores
    • Updated Node.js runtime requirement from version 20 to 24
    • Updated development dependencies including type definitions, code formatting and linting tools, bundler, and package manager to latest compatible versions

Signed-off-by: Guillaume Bonnet <mrsquaare@mrsquaare.fr>
@MrSquaare MrSquaare self-assigned this Mar 13, 2026
@MrSquaare MrSquaare linked an issue Mar 13, 2026 that may be closed by this pull request
Signed-off-by: Guillaume Bonnet <mrsquaare@mrsquaare.fr>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 13, 2026

📝 Walkthrough

Walkthrough

This PR updates the project to support Node.js 24, replacing Node.js 20 across GitHub Actions configuration, documentation, and package dependencies. Updates include action runtime specifications, GitHub Actions setup configuration, README documentation, and package.json engine requirements and tool versions.

Changes

Cohort / File(s) Summary
GitHub Actions Configuration
action.yml, .github/actions/setup-env/action.yml
Updated Node.js runtime from node20 to node24 in GitHub Action specifications.
Documentation
README.md
Updated usage note to reflect Node.js 24 runtime requirement and Runner v2.327.1+ dependency.
Dependencies & Engines
package.json
Updated @types/node (^20.19.37 → ^24.12.0), oxfmt (^0.36.0 → ^0.40.0), oxlint (^1.51.0 → ^1.55.0), rolldown (1.0.0-rc.7 → 1.0.0-rc.9), node engine (>=20 → 24), and pnpm (10.30.3 → 10.32.1).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • PR #56: Main PR that introduces the same Node.js 24 runtime and package engine updates across the same configuration files and package.json.

Poem

🐰 From twenty to twenty-four we hop,
Node's runtime takes a great big step,
GitHub Actions now deprecated no more,
Dependencies updated to the core,
Into the future our code will soar! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main changes: dependency bumps and Node.js 24 requirement.
Description check ✅ Passed The description includes the required sections (Related issue and Description) with relevant details about dependency bumps and Node.js 24 requirement.
Linked Issues check ✅ Passed The changes fully address issue #57 requirements: action.yml updated to node24, dependencies bumped, and Node.js 24 runtime requirement established.
Out of Scope Changes check ✅ Passed All changes are in scope: Node.js 24 support in action.yml, GitHub Actions setup, package.json dependencies, and documentation updates directly support the linked issue objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 57-support-node-24-for-github-actions-runners
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@action.yml`:
- Around line 29-30: The action currently sets the runner runtime to node24 via
the "runs: using: \"node24\"" entry which will break older self-hosted runners;
revert the runtime to the previous LTS (e.g., "node20") in action.yml for the
existing major (v3) release and instead introduce node24 in a new major release
(v4). Update the new major's action.yml to use "node24", add clear migration
notes in the release/changelog and README explaining the required self-hosted
runner minimum (v2.327.1+) and migration steps, and keep the existing
tag/version for consumers who must remain on node20 to avoid breaking them.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cd7fbf42-b262-4d3b-81d7-294df9409b6e

📥 Commits

Reviewing files that changed from the base of the PR and between c818628 and 60ce291.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .github/actions/setup-env/action.yml
  • README.md
  • action.yml
  • package.json

Comment thread action.yml
@MrSquaare MrSquaare merged commit 2a530e0 into main Mar 13, 2026
10 checks passed
@MrSquaare MrSquaare deleted the 57-support-node-24-for-github-actions-runners branch March 13, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Node 24 for GitHub Actions runners

1 participant