Refactor: Extract pod rendering logic from UIManager#5
Open
MrTyton wants to merge 1 commit into
Open
Conversation
Extracted the pod rendering functionality from the `ui-manager.ts` file into a new `pod-renderer.ts` module. - Created a new `PodRenderer` class in `src/pod-renderer.ts` to handle all DOM rendering of the generated pods. - Moved the `renderPods`, `renderPodsToDOM`, and `calculateValidBracketRange` methods from `UIManager` to the `PodRenderer` class. - Updated `UIManager` to instantiate and use the new `PodRenderer` class, delegating all pod rendering tasks to it. This refactoring improves the separation of concerns, reduces the size of the `ui-manager.ts` file, and makes the codebase more modular and maintainable, as requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the pod rendering functionality from the
ui-manager.tsfile into a newpod-renderer.tsmodule.PodRendererclass insrc/pod-renderer.tsto handle all DOM rendering of the generated pods.renderPods,renderPodsToDOM, andcalculateValidBracketRangemethods fromUIManagerto thePodRendererclass.UIManagerto instantiate and use the newPodRendererclass, delegating all pod rendering tasks to it.This refactoring improves the separation of concerns, reduces the size of the
ui-manager.tsfile, and makes the codebase more modular and maintainable, as requested.