Skip to content

Create heapsort.html#218

Closed
Venkatkalyan21 wants to merge 1 commit into
MrunaliniPachpute:mainfrom
Venkatkalyan21:main
Closed

Create heapsort.html#218
Venkatkalyan21 wants to merge 1 commit into
MrunaliniPachpute:mainfrom
Venkatkalyan21:main

Conversation

@Venkatkalyan21
Copy link
Copy Markdown

@Venkatkalyan21 Venkatkalyan21 commented Oct 29, 2025

🚀 Summary

This pull request adds the implementation of the Heap Sort algorithm to the repository.

🧠 Details

  • Implemented Heap Sort in [language used, e.g., C / C++ / Python].
  • Includes helper functions:
    • heapify() — to maintain the heap property.
    • heapSort() — to perform sorting.
  • Time Complexity: O(n log n)
  • Space Complexity: O(1)

🧪 Testing

  • Verified output with multiple test cases.
  • Works correctly for:
    • Sorted input
    • Reverse sorted input
    • Random input

📂 Files Changed

  • Added: heap_sort.[ext] (replace [ext] with .c, .cpp, .py, etc.)
  • Updated: README.md (added Heap Sort to the list of algorithms)

✅ Checklist

  • Code runs without errors
  • Proper comments added
  • Code follows repository style guidelines
  • README updated

@github-actions
Copy link
Copy Markdown

Thanks for creating a PR for your Issue! ☺️

Kindly Star the repo ⭐ We'll review Your PR as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@Venkatkalyan21
Copy link
Copy Markdown
Author

accept the pull request

@MrunaliniPachpute
Copy link
Copy Markdown
Owner

@Venkatkalyan21 What is this PR about kindly add proper description and link it to respective issue.

@Venkatkalyan21
Copy link
Copy Markdown
Author

Venkatkalyan21 commented Oct 30, 2025

@MrunaliniPachpute Check now

@MrunaliniPachpute
Copy link
Copy Markdown
Owner

@Venkatkalyan21
I noticed you’ve implemented Heap Sort — however, this algorithm already exists in the repository. I also see that you’ve contributed in multiple languages, which is great! That said, this repository follows a language-agnostic approach, focusing on pseudocode to ensure better understanding across all programming languages.

Additionally, it seems that this PR was raised without getting the corresponding issue assigned first. As per the contribution guidelines, please create an issue, get it assigned, and then proceed to open a PR. I’ll be closing this PR for now, but if your issue is valid, I’ll be happy to assign it to you.

I’d suggest checking out Issue #1 and Issue #120 — if you’re interested, comment under those and I’ll assign them to you.

Thank you!

@MrunaliniPachpute MrunaliniPachpute added the duplicate This issue or pull request already exists label Oct 30, 2025
@Venkatkalyan21
Copy link
Copy Markdown
Author

Okay assign #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants