Add trigger MC track modules to track fit sequences

[michaelmackenzie]

Follow the mu2e-trig-config change (Mu2e/mu2e-trig-config#130) that puts the Online track-fit instances in sequences, and move the MC matching modules into these sequences. This allows the simulation to no longer need to track the trigger path name changes or expansion in this MC matching, since the module will no longer depend on the filter decisions after the Online track fitting.

[FNALbuild]

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

• JobConfig

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 800eb22: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☔ The build tests failed for 800eb22.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 800eb22 at 1b4b11f
build (prof)	✅	Log file. Build time: 04 min 46 sec
ceSimReco	❌	Log file. Return Code 90.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	❌	Log file. Return Code 90.
cosmicOffSpill	❌	Log file. Return Code 90.
ceSteps	✅	Log file.
ceDigi	❌	Log file. Return Code 90.
muDauSteps	✅	Log file.
ceMix	❌	Log file. Return Code 90.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 0 files
clang-tidy	✅	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 800eb22 after being merged into the base branch at 1b4b11f.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[michaelmackenzie]

@FNALbuild run build test with Mu2e/mu2e-trig-config#130

[FNALbuild]

⌛ The following tests have been triggered for 800eb22: build (Build queue - API unavailable)

[FNALbuild]

☔ The build tests failed for 800eb22.

Test	Result	Details
test with	✅	Included Mu2e/mu2e-trig-config#130 @ 8660d8445806dc71b8c00863b29f9e4dad0848b7 by merge
merge	✅	Merged 800eb22 at 1b4b11f
build (prof)	✅	Log file. Build time: 09 min 39 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	❌	Log file. Return Code 90.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	❌	Log file. Return Code 90.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 0 files
clang-tidy	✅	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 800eb22 after being merged into the base branch at 1b4b11f.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[michaelmackenzie]

@FNALbuild run build test with Mu2e/mu2e-trig-config#130

[FNALbuild]

⌛ The following tests have been triggered for 1a3185b: build (Build queue - API unavailable)

[FNALbuild]

☀️ The build tests passed at 1a3185b.

Test	Result	Details
test with	✅	Included Mu2e/mu2e-trig-config#130 @ 8660d8445806dc71b8c00863b29f9e4dad0848b7 by merge
merge	✅	Merged 1a3185b at 1b4b11f
build (prof)	✅	Log file. Build time: 04 min 46 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 0 files
clang-tidy	✅	0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 1a3185b after being merged into the base branch at 1b4b11f.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[brownd1978]

Overall this seems an improvement, as it reduces digitization dependence on trigger configuration details (path names). It still depends on trigger sequences, which will hopefully be more stable and generic.

This might be a good time to standarize sequence and module instance names, as suggested for APR.

[brownd1978]

Why doesn't the TrigAprKSFMC instance name include De? It's in the sequence name, and all the other Trig*KSFMC instances are named that way.

[michaelmackenzie]

I agree that it should include De, I think this is a historical artifact for APR. I've renamed it here, and in a future PR I can rename the actual trigger KSF module as well (TrigAprKSF --> TrigAprDeKSF). I would also like to rename them all, as they don't follow a style in general right now (TrigKSFDe for TPR, TrigAprKSF for APR, TrigCalSeedFitDe for CPR, etc.)