Keep autocomplete from stealing editor focus#12
Open
adamsardo wants to merge 1 commit into
Open
Conversation
0920880 to
93c74cd
Compare
Author
|
Added the missing proof artifact to the PR body: a GIF generated from the actual edbee widget showing autocomplete open while editor focus remains active, Down arrow routing selection to the list, and normal typing still landing in the editor. I also added the focused regression test to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Mudlet/Mudlet#5310.
/claim #5310
/claim Mudlet/Mudlet#5310
Summary:
This is intentionally different from #11: it does not call
editorComponentRef_->setFocus()when autocomplete closes, so it should not steal focus back if the user already moved focus to another non-edbee widget.Proof:
The proof GIF is generated from the actual edbee widget. It shows autocomplete opening, Down arrow changing the list selection, and a typed
pbeing inserted into the editor while editor focus remains active and the autocomplete list does not receive focus.Verification:
git diff --checkcmake -S . -B build/codex-qt5 -DBUILD_WITH_QT5=ON -DCMAKE_PREFIX_PATH=/opt/homebrew/opt/qt@5 -DCMAKE_BUILD_TYPE=Debugcmake --build build/codex-qt5 --parallel 6QT_QPA_PLATFORM=offscreen ./build/codex-qt5/edbee-test/edbee-test(784 passed, 0 failures)