Merged
Conversation
Collaborator
Author
|
@FJanssen-TNO I have written an implementation for this issue. It is not ready for a proper PR, I still need to write some test and do all the formatting and linting, but if you have some time it would be useful for me if you can check if my approach for it makes sense. |
Collaborator
FJanssen-TNO
left a comment
FJanssen-TNO
left a comment
There was a problem hiding this comment.
First notes on the structure
src/mesido/pycml/component_library/milp/heat/geothermal_source_elec.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@FJanssen-TNO ready for review again. |
src/mesido/pycml/component_library/milp/heat/geothermal_source_elec.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@FJanssen-TNO I implemented all the comments. Ready again for review. |
src/mesido/pycml/component_library/milp/heat/geothermal_source_elec.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@FJanssen-TNO last comments fixed. |
FJanssen-TNO
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work for issue: #421