Conversation
|
@KobusVanRooyen, made an initial commit to this issue, where there is a slight improvement (~0.3s faster per call). I would still want to know if it could be sped up (exploratory), but I don't want to overdo it, so I would like to hear the requirements/what you think as well. |
@gopalangj 0.3s faster, nice. What is the ~percentage improvement? What was the original time [s] per call? |
|
|
||
| import rtctools.data.pi | ||
| from rtctools.data.storage import DataStore | ||
| from concurrent.futures import ThreadPoolExecutor |
There was a problem hiding this comment.
Please update your branch with main before doing further dev here
…zation/mesido into 412-efficient-influxdatabase-connections Pulling main into the branch before making any changes
…ifferent threads trying to access same object information that could lead to code corruption
There was a problem hiding this comment.
Can we make the names unique (instead of having exactly the same name --->> workers_db_profile_reading=workers_db_profile_reading) or change the one to self._workers_db_profile_reading?
There was a problem hiding this comment.
I would prefer to be set at only 1 place. Currently this is set to 4 when retrieving the kwargs. So I think we should not set it to 1 here. What do you think?
There was a problem hiding this comment.
should this not maybe be self._workers_db_profile_reading rather?
There was a problem hiding this comment.
Why is this code commented out?
There was a problem hiding this comment.
This should not be needed for reading from a file? So should this line not be deleted then?
| None, | ||
| ) | ||
| if not time_series_data: | ||
| with self._lock: |
There was a problem hiding this comment.
I would like to discuss this lock
| profile.endDate, | ||
| # Check if an object of the InfluxDBProfileManager is already present in a list. If so, | ||
| # re-use that object that was already created and been stored in the list. | ||
| time_series_data = next( |
There was a problem hiding this comment.
Why is this code repeated in the code below?
|
@gopalangj review completed. |
2 participants
No description provided.