Skip to content

add: suppress KRBAPIPrincipalNotFoundError during principal deletion #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rimu-stack merged 1 commit into from
Jan 21, 2026
Merged

add: suppress KRBAPIPrincipalNotFoundError during principal deletion #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/ldap_protocol/ldap_requests/add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
KRBAPIAddPrincipalError,
KRBAPIConnectionError,
KRBAPIDeletePrincipalError,
KRBAPIPrincipalNotFoundError,
)
from ldap_protocol.ldap_codes import LDAPCodes
from ldap_protocol.ldap_responses import INVALID_ACCESS_RESPONSE, AddResponse
Expand Down Expand Up @@ -456,7 +457,10 @@ async def handle( # noqa: C901
# stub cannot raise error
if user:
# NOTE: Try to delete existing principal if any
with contextlib.suppress(KRBAPIDeletePrincipalError):
with contextlib.suppress(
KRBAPIDeletePrincipalError,
KRBAPIPrincipalNotFoundError,
):
await ctx.kadmin.del_principal(
user.get_upn_prefix(),
)
Expand Down
2 changes: 1 addition & 1 deletion interface
Open in desktop
Submodule interface updated from 95ed5e to f31962