ci: isolate smoke-asset download and fix PR code-quality checkout - #924
Merged
Merged
Conversation
Akilan-Sivakumar
commented
Jul 24, 2026
Collaborator
- Fixes fork-PR CI failure: Refusing to check out fork pull request code from a 'pull_request_target' workflow.
- code-quality: adds allow-unsafe-pr-checkout: true to opt in (this job only reads changed files - it never builds/runs PR code) and persist-credentials: false so the token isn't left on disk.
- Adds a prep-assets job that downloads the smoke tarballs with the asset token and republishes them as an internal smoke-assets artifact - it checks out no PR code, so the token can't be exfiltrated.
- smoke-linux and smoke-windows now consume that artifact instead of holding the token, keeping the secret out of every job that runs fork code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.