fix(tme): add multi-pool subscription for ThreadedME - #925
Open
shashankp-mcw wants to merge 1 commit into
Open
Conversation
…-split rule table - fixes side-effect of 084f9e8 - fixes MAX_NODE_NUM to be consistent with 64 bit nodemask bitmaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--threaded-mewas enabled, ThreadedME was pinned to a single threadpool could exceed 64 threads. This breaks the thread state tracking assleepbitmap_tis only valid upto 64 threads. This broken behaviour ofsleepbitmap_twas fixed by 084f9e8. However, the rule table of ThreadedME specified inconfigureTmeThreadCountwas not accounted for. Some of the thread splits may exceed 64 threads and would need the ThreadedME singleton to subscribe to many pools at once.With this PR:
distributeThreadsForTmeto split resource groups into TME-first and then frame-encoder groups.cli.rst,threading.rst) to describe the multi-pool model.MAX_NODE_NUMto be consistent with 64-bit nodemask bitmaps. Previously this value was 127, which can't be represented by a 64-bit integer.