Skip to content

fix(CE): remove unsupported API key banner from Edit Sync manual schedule (#1773) #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aisquared-ci-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(CE): remove unsupported API key banner from Edit Sync manual schedule (#1773) #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ui/src/views/Activate/Syncs/EditSync/EditSync.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import MapCustomFields from '../SyncForm/ConfigureSyncs/MapCustomFields';
import { useStore } from '@/stores';
import BaseButton from '@/components/BaseButton';
import { FiRefreshCcw } from 'react-icons/fi';
import AlertBox from '@/components/Alerts/Alerts';
import useEditSync from '@/hooks/syncs/useEditSync';
import useManualSync from '@/hooks/syncs/useManualSync';
import useSyncRuns from '@/hooks/syncs/useSyncRuns';
Expand Down Expand Up @@ -248,15 +247,6 @@ const EditSync = (): JSX.Element | null => {
</>

<ScheduleForm formik={formik} isEdit />
{formik.values.schedule_type === 'manual' && (
<Box marginTop='20px' marginBottom='100px'>
<AlertBox
title='Trigger syncs using API keys'
description='You can also trigger this sync using Airflow, Dagster, or Prefect. If you need an API key, please create one in the Settings page.'
status='info'
/>
</Box>
)}
</React.Fragment>
) : null}
<FormFooter
Expand Down
4 changes: 4 additions & 0 deletions ui/src/views/Activate/Syncs/EditSync/ScheduleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ const ScheduleForm = ({ formik, isEdit }: ScheduleFormProps) => {
backgroundColor={isEdit ? 'gray.100' : 'gray.200'}
padding='24px'
borderRadius='8px'
<<<<<<< HEAD
marginBottom={'100px'}
=======
marginBottom='100px'
>>>>>>> 4c71dc38e (fix(CE): remove unsupported API key banner from Edit Sync manual schedule (#1773))
>
<Text fontWeight='semibold' mb='6' size='md'>
Finalise setting for this sync
Expand Down
Loading
Loading