Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR brings quality of life improvements to filter processors by implementing subset collections for better memory performance, fixing hit-to-simhit relation propagation bugs, and adding 3D distance-based filtering capabilities.
- Refactored filter processors to use subset collections instead of creating new hit objects, reducing memory overhead
- Fixed bug in hit-to-simhit relation propagation by properly using LCRelationNavigator
- Added argument to filter tracker hits based on 3D distance from helix in addition to angular distance
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| source/Utils/src/FilterTracks.cc | Added debug logging for calorimeter state filtering |
| source/Utils/src/FilterTimeHits.cc | Refactored to use subset collections and fixed relation handling with LCRelationNavigator |
| source/Utils/src/FilterConeHits.cc | Major refactor using subset collections, added 3D distance filtering, and improved relation handling |
| source/Utils/src/FilterClusters.cc | Enhanced with subset collections, improved theta binning logic, and added diagnostic histograms |
| source/Utils/include/FilterConeHits.h | Added member variable for 3D distance cut parameter |
| source/Utils/include/FilterClusters.h | Added histogram members and reorganized class structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…cessors into subset_collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in a few quality of life improvements
BEGINRELEASENOTES
ENDRELEASENOTES