Skip to content

Add macOS Apple Silicon build matrix entry#954

Open
nirinarakotobe wants to merge 1 commit into
Murmele:masterfrom
nirinarakotobe:release/macos-apple-silicon
Open

Add macOS Apple Silicon build matrix entry#954
nirinarakotobe wants to merge 1 commit into
Murmele:masterfrom
nirinarakotobe:release/macos-apple-silicon

Conversation

@nirinarakotobe
Copy link
Copy Markdown

@nirinarakotobe nirinarakotobe commented May 9, 2026

Summary

  • Add a macOS Apple Silicon entry to the existing build matrix in .github/workflows/build.yml.
  • Use GitHub's arm64 macOS runner with CMAKE_OSX_ARCHITECTURES=arm64.
  • Keep the existing macOS libssh2 configuration by using USE_SSH:STRING=localbuild.
  • Include both Intel and Apple Silicon macOS packages in the release upload file list.

Validation

  • Parsed .github/workflows/build.yml locally with Ruby YAML.
  • Locally corrected the Apple Silicon configure command after confirming USE_SSH:STRING=localbuild is required to avoid the libssh2 resolution error.
  • GitHub Actions previously passed for the macOS arm64 matrix entry.

Notes

  • This replaces the earlier standalone Apple Silicon workflow approach and keeps macOS packaging inside the existing workflow.

@nirinarakotobe nirinarakotobe marked this pull request as ready for review May 10, 2026 09:03
@Murmele
Copy link
Copy Markdown
Owner

Murmele commented May 14, 2026

Thanks you! Would it possible to integrate into the build.yml file. Did you try if the resulting macos package is running fine?

@nirinarakotobe
Copy link
Copy Markdown
Author

nirinarakotobe commented May 14, 2026

I have not fully tested the complete workflow locally yet, but the macOS build itself is working properly. I also created a fork to integrate the macOS-specific style.

And yes, I agree it should be integrated into the existing .github/workflows/build.yml instead of adding a separate workflow. I have updated the PR accordingly: the standalone workflow has been removed, and a macos-arm64 entry has been added to the existing build matrix, using GitHub’s macos-15 arm64 runner and CMAKE_OSX_ARCHITECTURES=arm64.

@nirinarakotobe nirinarakotobe force-pushed the release/macos-apple-silicon branch from 68d3dfe to cb4642a Compare May 14, 2026 12:15
@nirinarakotobe nirinarakotobe changed the title Add macOS Apple Silicon release workflow Add macOS Apple Silicon build matrix entry May 14, 2026
Comment thread .github/workflows/build.yml Outdated
Comment on lines 387 to 389
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanna have it in the release you have to add it here

@nirinarakotobe nirinarakotobe force-pushed the release/macos-apple-silicon branch from cb4642a to 9b56b78 Compare May 18, 2026 05:35
@Murmele
Copy link
Copy Markdown
Owner

Murmele commented May 18, 2026

The resulting macos build is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants