Add caching of settings#958
Merged
Murmele merged 1 commit intoMay 17, 2026
Merged
Conversation
AHSauge
force-pushed
the
fix/cache-show-changed-files-as-list
branch
from
d5ba660 to
fe20254
Compare
AHSauge
changed the title
Contributor
Author
|
I'm realising that it's quite easy to just cache any settings, so I rewrote the code to do that. As a consequence, this also improves performance outside of |
AHSauge
force-pushed
the
fix/cache-show-changed-files-as-list
branch
from
fe20254 to
6ff9f62
Compare
Murmele
reviewed
May 14, 2026
Murmele
reviewed
May 14, 2026
The underlying code creates a QSettings object for each request, resulting in excessive file reads and slow-downs
AHSauge
force-pushed
the
fix/cache-show-changed-files-as-list
branch
from
6ff9f62 to
9bc33b1
Compare
Murmele
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a performance regression introduced in #664.
The underlying code creates a QSettings object for each request, resulting in excessive file reads and slow-downs. By caching the value the cost of running
RepoView::diffSelectedis reduced by 10+ms (it seems to scale with the complexity of the commit)