Skip to content

Fix crash in 'Filter by Path' due to out-of-bound access #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Murmele merged 1 commit into from
May 17, 2026
Merged

Fix crash in 'Filter by Path' due to out-of-bound access #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/index/Index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,13 @@ QList<git::Commit> Index::commits(const QList<Posting> &postings) const {
// Look up commits.
QSet<git::Commit> commits;
foreach (const Posting &posting, postings) {
// FIXME: Remove deleted commits on write.
if (git::Commit commit = mRepo.lookupCommit(mIds.at(posting.id)))
commits.insert(commit);
// If we fail this check, then the index is mismatching the repo
// The FIXME below might be the cause of that
if (posting.id < mIds.size()) {
// FIXME: Remove deleted commits on write.
if (git::Commit commit = mRepo.lookupCommit(mIds.at(posting.id)))
commits.insert(commit);
}
}

return commits.values();
Expand Down
Loading