Fix qt.qpa.services: Failed to register with host portal#969
Draft
AHSauge wants to merge 1 commit into
Draft
Conversation
The files need to match the identifier used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files need to match the identifier used
I need to test this a bit more, but at least on Fedora, there's no question that the desktop file needs to match the app ID, aka. it needs to be named
com.github.Murmele.Gittyup.desktopotherwise I getThis quite likely impacts the integration with the desktop environment, which could explain #891.
What I'm quite sceptical about is the
setApplicationNameinApplication::Application. It sets it toGITTYUP_NAMEwhich isGittyup. However, in the desktop file we haveStartupWMClass=com.github.Murmele.Gittyup, and if I read https://linuxvox.com/blog/what-represents-startupwmclass-entry-from-a-desktop-file-in-ubuntu/ correctly, what is set insetApplicationNameshould matchStartupWMClass, which it clearly doesn't.