Skip to content

fix: add integer overflow check in audio.c... #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: add integer overflow check in audio.c... #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion common/audio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ void init_fe_bgm(int *fe_bgm, int bgm_type, int re_init) {
}

size_t capacity = 8;
bgm_files = malloc(capacity * sizeof(char *));
bgm_files = calloc(capacity, sizeof(char *));
if (!bgm_files) {
LOG_ERROR("audio", "%s", lang.system.fail_allocate_mem);
closedir(dir);
Expand All @@ -239,6 +239,12 @@ void init_fe_bgm(int *fe_bgm, int bgm_type, int re_init) {
if (bgm_file_count >= capacity) {
capacity <<= 1;

if (capacity > SIZE_MAX / sizeof(char *)) {
LOG_ERROR("audio", "%s", lang.system.fail_allocate_mem);
closedir(dir);
return;
}

char **bgm_temp = realloc(bgm_files, capacity * sizeof(char *));

if (!bgm_temp) {
Expand Down