ci(lint): lint the full tree, not just the diff#487
Open
krisarmstrong wants to merge 1 commit into
Open
Conversation
Backlog cleared and verified: golangci-lint v2.12.2 full-tree run on origin/main reports 0 issues. Drop --new-from-rev=HEAD~1 so CI enforces zero warnings across the whole repo instead of only changed lines. Related to #486
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop
--new-from-rev=HEAD~1from the golangci-lint step so CI lints the whole tree instead of only changed lines. The pre-existing backlog that blocked this earlier is gone — a full-treegolangci-lint v2.12.2run onorigin/mainreports 0 issues.Linked Issue
Related to #486
Testing Evidence
Security and Release Checklist