Scrub MCWS user ID of invalid namespace characters #391
Open
mudinthewater wants to merge 2 commits intorelease/5.3.2from
Open
Scrub MCWS user ID of invalid namespace characters #391mudinthewater wants to merge 2 commits intorelease/5.3.2from
mudinthewater wants to merge 2 commits intorelease/5.3.2from
Conversation
…racters to support full name returns from identity service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for #387 in v5.3.2.
This can't be tested with development storage, so you'll need something to emulate the MCWS persistence storage, as well as send a poorly-formatted name.
Line 26:
import_mcws_namespaces = true -> import_mcws_namespaces = falseLine 40:
import_fastmio_namespaces=false -> import_fastmio_namespaces=trueLines 44-48:
becomes
Fastmio is now configured to send your development server a MCWS namespace with an invalid ID.
Run fast mio with python fastmio/fastMIOServer.py and leave the terminal up for your testing purposes.
Note that you may need to delete the contents of while you test - fastmio will automatically pick up any changes to the and does not need to be restarted if you do.
Next, configure the webpack dev environment and config.js to use the fastmio environment you just set up.
Webpack dev:
set your API_URL environment variable to localhost:8093
config.js
mcwsUrl: 'http://localhost:8093/mcws',uncomment the proxyUrl line, but do not uncomment the useDeveloperStorage line, as we're going to use fastmio in this scenario as our test storage provider. Don't forget to remove the comma after useDeveloperStorage if it is now the last item in the config file.
running npm start should now run MCT as a developer server but with fastmio providing a fully qualified mcws-like name, allowing this functionality to be tested .
Verify that the user folder is automatically created with the full user name and that the logged in user in the MCT status bar is the correct user name.
Verify that if you create an object in the user's folder, the namespace and location parameters do not contain spaces, commas, or other invalid characters.
Verify that you can create objects in the shared folder with no issues as well.