Skip to content

392 force uppercase module subscriptions#394

Open
mudinthewater wants to merge 3 commits intorelease/5.3.2from
392-force-uppercase-module-subscriptions
Open

392 force uppercase module subscriptions#394
mudinthewater wants to merge 3 commits intorelease/5.3.2from
392-force-uppercase-module-subscriptions

Conversation

@mudinthewater
Copy link
Copy Markdown
Collaborator

@mudinthewater mudinthewater commented Feb 5, 2026

Fixes: #392

  1. Corrects order of operations in assigning a module to an EVR stream request.

Before:
domainObject.telemetry.definition.module first
domainObject.telemetry.evr_name.split("_")[0] if evr_name existed
domainObject.telemetry.module third

This caused it to break if modules had an underscore in them, and would also cause it to default to the legacy EVR name method before using the module definition from the dictionary.

Now:
domainObject.telemetry.definition.module first
domainObject.telemetry.module second
domainObject.telemetry.evr_name.split("_")[0] as a last ditch resort.

This should work for cases where the module has underscores now, as the module provided by the EVR dictionary will be used in all cases before trying to assume a module from the evr name.

  1. Makes module stream requests all caps and all internally consistent.
    There were instances where an EVR return would have an all caps module name, but OMM was forcing all lowercase module names in the evr stream. This caused a disconnect with the MCWS return so no EVRs would appear in module streams.

MCWS is case-agnostic for EVR streams, so best method here is to make stream requests internally consistent - other filters use all caps already (well, they use the dictionary default which is all caps), so we should also use it for both the request and the key.

@mudinthewater
Copy link
Copy Markdown
Collaborator Author

NOTE:

  1. MCWS appears to be case-agnostic for all filters. We should verify this, in particular check that these are case agnostic:

    if (messageType === 'CommandMessages') {

  2. DO not merge this until: every key has been uppercased. The above code is either:

a. Assuming the key is uppercase (bad and what originally got us in this mess)
b. Forcing an uppercase filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant